Walkthrough

Adds CMake property-parsing helpers and reads uiDensity from device.properties for multiple devices. Removes UiDensity from the HAL Configuration and deletes related C ABI wrappers. Introduces LVGL-facing compile definitions and a new function lvgl_get_ui_density() with updated public macros. Replaces HAL-based density checks across many UI sources to use the LVGL API. Adds I2C register8 operations to the kernel driver API and symbol table. Implements I2S and I2C controller-based power/sound initialization and device tree updates for the M5Stack Tab5.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

Devices/m5stack-tab5/Source/Configuration.cpp (1)

69-71: initPower discards the actual error and always returns ERROR_UNDEFINED.

The error variable already holds the specific error from i2c_controller_write_register_array, but the function returns a generic ERROR_UNDEFINED instead. In contrast, initSound correctly propagates the real error via return error. Consider returning error here as well for consistent and more informative error reporting.

Suggested diff

     auto error = i2c_controller_write_register_array(i2c_controller, IO_EXPANDER1_ADDRESS, reg_data_io1_1, sizeof(reg_data_io1_1), pdMS_TO_TICKS(100));
     if (error != ERROR_NONE) {
         LOG_E(TAG, "IO expander 1 init failed in phase 1");
-        return ERROR_UNDEFINED;
+        return error;
     }
 
     constexpr auto IO_EXPANDER2_ADDRESS = 0x44;
     error = i2c_controller_write_register_array(i2c_controller, IO_EXPANDER2_ADDRESS, reg_data_io2, sizeof(reg_data_io2), pdMS_TO_TICKS(100));
     if (error != ERROR_NONE) {
         LOG_E(TAG, "IO expander 2 init failed");
-        return ERROR_UNDEFINED;
+        return error;
     }
 
     // The M5Stack code applies this, but it's not known why
     // TODO: Remove and test it extensively
     tt::kernel::delayTicks(10);
 
     error = i2c_controller_write_register_array(i2c_controller, IO_EXPANDER1_ADDRESS, reg_data_io1_2, sizeof(reg_data_io1_2), pdMS_TO_TICKS(100));
     if (error != ERROR_NONE) {
         LOG_E(TAG, "IO expander 1 init failed in phase 2");
-        return ERROR_UNDEFINED;
+        return error;
     }

Also applies to: 76-78, 86-88

• X
• Mastodon
• Reddit
• LinkedIn